Skip to content

Commit

Permalink
fix: failing to find headers when linked with Pods. (#75)
Browse files Browse the repository at this point in the history
Summary:
---------

Multiple people have reported that RNCAsyncStorage fails to build after #35. See #35 (comment), #73, and #74.

After a little discussion, we agreed to rename the `.podspec` and the name of the Pod to be more in line with Apple's naming guidelines and the rest of the community. Unfortunately, this means that the next upgrade will break.

I got a little impatient knowing that I broke the latest release so I went ahead and implemented the fix. Sorry if you've already started looking at this.

Migration Plan:
---------------

Even though `react-native link` will be able to link the new `.podspec`, it won't clean up existing entries. Please find your Podfile, and make the following changes:

```diff
- pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage'
+ pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage'
```
  • Loading branch information
tido64 authored and Krzysztof Borowy committed Apr 14, 2019
1 parent 42fec96 commit 5ab6602
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require 'json'
package = JSON.parse(File.read(File.join(__dir__, 'package.json')))

Pod::Spec.new do |s|
s.name = "react-native-async-storage"
s.name = "RNCAsyncStorage"
s.version = package['version']
s.summary = package['description']
s.license = package['license']
Expand Down
4 changes: 2 additions & 2 deletions docs/Linking.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@
#### Using 'Pods'
1. Enter into iOS Folder `cd ios/` (on your project's root folder).

2. Add this line to your `Podfile` just below the last pod: (if you don't one just create a new runnning: `pod init`).
2. Add this line to your `Podfile` just below the last pod (if you don't have one, you can create it by running `pod init`):

```diff
+ pod 'react-native-async-storage', :path => '../node_modules/@react-native-community/async-storage'
+ pod 'RNCAsyncStorage', :path => '../node_modules/@react-native-community/async-storage'
```

3. Run `pod install`
Expand Down

0 comments on commit 5ab6602

Please sign in to comment.