fix: resolve CLI through react-native to avoid hoisting issues #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cocoapods tests are failing, because there's no |
thymikee
commented
Feb 14, 2020
| @@ -15,7 +15,8 @@ def use_native_modules!(config = nil) | |||
| config = nil; | |||
| end | |||
|
|
|||
| cli_resolve_script = "console.log(require('@react-native-community/cli').bin);" | |||
| # Resolving the path the RN CLI. The `@react-native-community/cli` module may not be there for certain package managers, so we fall back to resolving it through `react-native` package, that's always present in RN projects | |||
| cli_resolve_script = "try {console.log(require('@react-native-community/cli').bin);} catch (e) {console.log(require('react-native/cli').bin);}" | |||
There was a problem hiding this comment.
cc @alloy in reality this try/catch is only necessary for testing environment. Do you think it's better to leave this or somehow detect we're in "test" environment and change path accordingly? (usually a bad idea in my experience)
There was a problem hiding this comment.
Might be better to mock execute_command instead?
thymikee
added a commit
that referenced
this pull request
Feb 14, 2020
* fix: resolve CLI through react-native to avoid hoisting issues * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
See #406 (comment) for explanation what happens.
This PR makes use of a fact, that CLI is available under https://github.com/facebook/react-native/blob/master/cli.js, which works regardless of package manager hoisting strategy. It doesn't make us closer to PnP support because we're making assumption we have
react-nativein the node_modules tree without declaring a dependency, but we can fix that later.Fixes #406
Test Plan:
CLI is properly resolved under
npm.