build: use template from react-native #84
Conversation
|
We will need to update path here: https://github.com/react-native-community/react-native-cli/blob/master/packages/local-cli/upgrade/upgrade.js#L143 too. |
|
I was unable to get it up & running locally, so let's go through it once again, when the above is resolved too. |
| destPath, | ||
| newProjectName | ||
| const templatePath = path.resolve( | ||
| process.cwd(), |
There was a problem hiding this comment.
I think this needs to be destPath (the project directory, passed from init()) instead of the current working directory (which could be any dir where the command to create a project was run).
There was a problem hiding this comment.
actually we could just use require.resolve('react-native/template') instead, since we are in context of node_modules, right?
Note that destPath is still passed on line 32. The diff might be confusing, but we are only changing the "path.resolve(__dirname, '../templates/HelloWorld')," part.
There was a problem hiding this comment.
Yeah, require.resolve should work I think.
Remove
templatesfromreact-native-cliand use template fromreact-nativerepo.Tests:
Used https://github.com/verdaccio/verdaccio to create local distributions of
react-nativeandreact-native-local-cliand initialized project using those packages