imp: Migrate platform-android to Typescript
#597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 29, 2019
thymikee
reviewed
Jul 29, 2019
packages/platform-android/src/commands/runAndroid/__tests__/runOnAllDevices.test.ts
Show resolved
Hide resolved
thymikee
reviewed
Jul 29, 2019
packages/platform-android/src/commands/runAndroid/runOnAllDevices.ts
Outdated
Show resolved
Hide resolved
packages/platform-android/src/commands/runAndroid/tryLaunchAppOnDevice.ts
Outdated
Show resolved
Hide resolved
packages/platform-android/src/link/patches/__tests__/applyParams.test.ts
Outdated
Show resolved
Hide resolved
packages/platform-android/src/link/warnAboutManuallyLinkedLibs.ts
Outdated
Show resolved
Hide resolved
thymikee
reviewed
Jul 31, 2019
|
Anything more to add here? |
|
@thymikee I was thinking about making an additional package just for common types, but it might be better to make this package while migrating |
|
Yep, let's do it then or as a separate PR, not necessary now |
thymikee
approved these changes
Jul 31, 2019
* origin/master: imp: optimize gradle code generation (#603) v2.8.2 fix: corrects `srcDirs` to be compatible with Kotlin projects (#602) v2.8.1 fix: fallback to default terminal if wrong one passed (#601) fix: adding back `projectRoot` to option (#588) fix: init run instructions to show workspace (#566)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
All of the files inside
platform-androidwere migrated to TS. Some of the types from common Flow definitions were moved toplatform-android/types.ts. Some of them are strictly connected to the android package, but some of them will need to be moved to a common package with types. I've added@ts-ignorein some places, they will need to be adjusted in the future.TODO:
Adjust common types- will add a separate package while extracting next packageTest Plan:
Unit test and CI are passing