Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: safe check for config command #589

Merged
merged 1 commit into from
Jul 29, 2019
Merged

fix: safe check for config command #589

merged 1 commit into from
Jul 29, 2019

Conversation

stephenlacy
Copy link
Contributor

Summary:

Fixes issues building for android when react-native.config.js has packages with platforms filter

Test Plan:

With the latest version of cli create/modify the react-native.config.js with a package and any platform as such:

module.exports = {
  dependencies: {
    'interactable': {
      platforms: {
        ios: null, 
      },
    },
    'appcenter': {
      platforms: {
        android: null,
      },
    },
  }
}

The cli will build without throwing the error TypeError: Cannot convert undefined or null to object at Function.keys () at isValidRNDependency

@thymikee thymikee changed the title fix: dependency check for commands/config fix: safe check for config command Jul 29, 2019
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee thymikee merged commit eddfd4d into react-native-community:master Jul 29, 2019
@stephenlacy stephenlacy deleted the fix-platform-config branch July 29, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants