Add ability to reload all connected devices and simulators #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Jul 23, 2019
|
FYI @Esemesek has an idea to put a "Reload" button into the debugger UI, which would be a good starter to overhaul it :) |
|
It looks like I might need some help on the iOS side to fix the reliability of the socket connection from the app to metro which makes this work. As it is today it seems like this doesn’t work reliably in open source, at least not for me. Let’s hold off a bit on being loud about this maybe. Once we have a release with this I can hopefully ask for some help in discord Edit, cool 2.8.0 was published with this |
|
The connection reliability was fixed in this commit facebook/react-native@4ab9da1 We can talk about this as loudly as we'd like now. :) |
This was referenced Aug 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
At Facebook we have a hotkey hooked up to the ability to reload all connected devices and simulators. This is incredibly useful! However, we make this work by deploying an app to everyone's laptop that listens for a global hotkey to tell metro to reload. Since it isn't feasible to do that in open source, this seems like a reasonable approach.
This PR adds the ability to hit the server host /reload, for example:
http://localhost:8081/reloadand metro will send a command to reload all connected apps.Personally, I plan on wiring up a hotkey with better touch tool to curl this endpoint. I imagine people can set up alfred workflows or wire it into other apps too.
Test Plan: