Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports the fix from #370 to the 1.x branch. I cherry picked 809aef9 to 1.x.
Summary:
The
loadConfig
function inmetro-config
reads thereporter
optionfrom the second argument (
defaultConfigOverrides
) instead of thefirst argument (
argv
), so we need to pass it in that object tomake the
customLogReporterPath
CLI option work.Test Plan:
reporter.js
with the following contents: