-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Metro config from CLI config #30
Changes from 29 commits
4396a67
0995784
b1ae80e
18c0e7b
b3cce4e
e3f44c0
aba53ce
e32d6c7
6d3afbf
6e21ad5
c5d3e41
9793d32
cb76d47
cf98b5a
15e43ba
038c190
213c130
ae258fd
372084a
a67fe59
e2fa20b
46c9ae2
b9ca8b7
3cb7bc6
5bf9c71
40528b0
63fbef1
1560725
f20605e
7a67759
da4136d
4407e42
2925aa2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ | |
jest.mock('path'); | ||
jest.mock('fs'); | ||
|
||
const findAssets = require('../findAssets'); | ||
const { findAssets } = require('../getAssets'); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yo, your prettier config should not have these whitespaces. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well, we don't have prettier set up in the repository just yet. I was waiting till we finish "migration" with that and then, I started this PR. I was planning to use our own preset https://github.com/callstack/eslint-config-callstack as it already has That way we only need to run I would suggest to "temporarily" ignore styling issues (as long as they are not that "annoying") and I'll follow up with "prettier" PR right after this one is merged. |
||
const dependencies = require('../__fixtures__/dependencies'); | ||
const fs = require('fs'); | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of
(val: string) => (val === 'false' ? false : true)
, you could do!!JSON.parse(val)