Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cli-plugin-metro package remnants #2272

Merged
merged 2 commits into from
Jan 23, 2024
Merged

chore: remove cli-plugin-metro package remnants #2272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f09489
chore: remove deprecated `cli-plugin-metro` package
szymonrybczak Jan 23, 2024
6014f73
docs: remove `cli-plugin-metro` from `CONTRIBUTING.md`
szymonrybczak Jan 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ _Note: you must use the `--watchFolders` flag with the `start` command when test

Because of a modular design of the CLI, we recommend developing using symbolic links to its packages. This way you can use it seamlessly in the tested project, as you'd use the locally installed CLI. Here's what you need to run in the terminal:

> [!NOTE]
> `@react-native-community/cli-plugin-metro` has been relocated as [`@react-native/community-cli-plugin`](https://github.com/facebook/react-native/tree/main/packages/community-cli-plugin). To make new contributions to this package, please open a PR in the [React Native repo](https://github.com/facebook/react-native) ([contributing guide](https://github.com/facebook/react-native/tree/main/packages/community-cli-plugin#contributing)).

#### yarn v1

```sh
Expand Down
7 changes: 0 additions & 7 deletions packages/cli-plugin-metro/README.md
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions packages/cli-plugin-metro/package.json
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"@react-native-community/cli-debugger-ui": "13.5.1-alpha.0",
"@react-native-community/cli-doctor": "13.5.1-alpha.0",
"@react-native-community/cli-hermes": "13.5.1-alpha.0",
"@react-native-community/cli-plugin-metro": "13.5.1-alpha.0",
"@react-native-community/cli-server-api": "13.5.1-alpha.0",
"@react-native-community/cli-tools": "13.5.1-alpha.0",
"@react-native-community/cli-types": "13.5.1-alpha.0",
Expand Down
7 changes: 1 addition & 6 deletions scripts/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,19 +11,14 @@ const chalk = require('chalk');
const stringLength = require('string-length');

const PACKAGES_DIR = path.resolve(__dirname, '../packages');
const REMOVED_PACKAGES = new Set(['cli-plugin-metro']);

const OK = chalk.reset.inverse.bold.green(' DONE ');

function getPackages() {
return fs
.readdirSync(PACKAGES_DIR)
.map((file) => path.resolve(PACKAGES_DIR, file))
.filter(
(f) =>
fs.lstatSync(path.resolve(f)).isDirectory() &&
!REMOVED_PACKAGES.has(path.basename(f)),
);
.filter((f) => fs.lstatSync(path.resolve(f)).isDirectory());
}

function adjustToTerminalWidth(str) {
Expand Down