Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable editTemplate test on Node v20 #2235

Merged
merged 1 commit into from
Dec 22, 2023
Merged

chore: disable editTemplate test on Node v20 #2235

merged 1 commit into from
Dec 22, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Looks like there's one more flaky test... Example failure.

Test Plan:

CI

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the infra Internal work not facing public APIs label Dec 22, 2023
thymikee
thymikee approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these are related to the unit test that fails

@thymikee thymikee merged commit c0c0cfa into main Dec 22, 2023
10 checks passed
@thymikee thymikee deleted the chore/skip-flaky-unit-test branch December 22, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz adamTrz is a code owner

Assignees
No one assigned
Labels
infra Internal work not facing public APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonrybczak @thymikee