Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add strict typing for supported platforms #2218

Merged
merged 1 commit into from
Dec 20, 2023
Merged

feat: add strict typing for supported platforms #2218

merged 1 commit into from
Dec 20, 2023

Conversation

okwasniewski
Copy link
Contributor

@okwasniewski okwasniewski commented Dec 20, 2023 •
edited
Loading

Summary:

This PR adds strict typing for supported platforms inside of cli-platform-apple.

Part of #2217

Test Plan:

CI Green

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@okwasniewski okwasniewski force-pushed the feat/cli-platform-apple-types branch 2 times, most recently from 9be3476 to da7a67e Compare December 20, 2023 12:42
@okwasniewski
Copy link
Contributor Author

I think this is also ready to merge cc: @thymikee

@thymikee thymikee merged commit 6eb9595 into react-native-community:main Dec 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@cipolleschi cipolleschi Awaiting requested review from cipolleschi cipolleschi is a code owner

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okwasniewski @thymikee