fix(ios): run-ios command
#2173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cipolleschi |
Comment on lines
397
to
398
| // if the project with the name already has cache, remove the cache to avoid problems with pods installation | ||
| cacheManager.removeProjectCache(projectName); |
There was a problem hiding this comment.
Hm, the same scenario could be if someone clones repo?
There was a problem hiding this comment.
yeah, but is there any way to prevent that in this scenario? 🤔
thymikee
reviewed
Nov 27, 2023
Comment on lines
52
to
56
| const fullPath = path.resolve(getCacheRootPath(), name); | ||
|
|
||
| if (fs.existsSync(fullPath)) { | ||
| fs.rmSync(fullPath, {recursive: true}); | ||
| } |
There was a problem hiding this comment.
let's add some error handling for the fs and resolve operations
|
Would appreciate tests for these scenarios 🙌🏼 |
TMisiukiewicz
force-pushed
the
fix/handle-pods
branch
from
366172c to
30e3ea9
Compare
|
@thymikee thanks for your review, done! |
thymikee
reviewed
Nov 28, 2023
|
|
||
| let dirFiles = fs.readdirSync(path.join(DIR, PROJECT_NAME)); | ||
|
|
||
| expect(dirFiles).toContain('react-native.config.js'); |
There was a problem hiding this comment.
we could also validate what's inside
thymikee
reviewed
Nov 28, 2023
Comment on lines
61
to
65
| logger.error( | ||
| `Failed to remove cache for ${name}. If you experience any issues when running freshly initialized project, please remove ${chalk.underline( | ||
| path.join(cacheRootPath, name), | ||
| )} folder manually.`, | ||
| ); |
There was a problem hiding this comment.
Suggested change
| logger.error( | |
| `Failed to remove cache for ${name}. If you experience any issues when running freshly initialized project, please remove ${chalk.underline( | |
| path.join(cacheRootPath, name), | |
| )} folder manually.`, | |
| ); | |
| logger.error( | |
| `Failed to remove cache for ${name}. If you experience any issues when running freshly initialized project, please remove the "${chalk.underline( | |
| path.join(cacheRootPath, name), | |
| )}" folder manually.`, | |
| ); |
thymikee
approved these changes
Nov 28, 2023
| function removeProjectCache(name: string) { | ||
| const cacheRootPath = getCacheRootPath(); | ||
| try { | ||
| const fullPath = path.resolve(cacheRootPath, name); |
There was a problem hiding this comment.
nit: we can move fullPath outside try catch and re-use it in catch statement.
szymonrybczak
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixing numerous small issues that could lead for potential breaking
run-ioscommand:run-ioswas called for the first time, and Pods were not installed duringinit, after installation it was trying to runxcodebuildcommand with.xcodeprojinstead of.xcworkspacebundle installstep inrun-ios--versionflag was used with < 0.73, pods had trouble installing because unknown flag was used in the config (this scenario will fail unless 0.73 islatest, if you are experiencing it, it's becauselatestis used when--versionflag is not used)Test Plan:
node ../path/to/cli init RN73RC5 --version 0.73.0-rc.5nrun-iosrm -rf RN73RC5node ../path/to/cli init RN73RC5 --version 0.73.0-rc.5yrun-iosChecklist