fix(ci): setup global git user #2157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Let's set the user in CI config, should allow us to not modify the test code |
szymonrybczak
force-pushed
the
fix/dynamically-assign-expected-files
branch
from
ac4fac1 to
8dbef75
Compare
szymonrybczak
changed the title
szymonrybczak
force-pushed
the
fix/dynamically-assign-expected-files
branch
from
af246d8 to
80870fd
Compare
szymonrybczak
force-pushed
the
fix/dynamically-assign-expected-files
branch
from
80870fd to
8590b80
Compare
szymonrybczak
force-pushed
the
fix/dynamically-assign-expected-files
branch
from
4be15b0 to
668b13f
Compare
Done, CI Green ✅ |
szymonrybczak
commented
Nov 6, 2023
| @@ -47,6 +47,9 @@ jobs: | |||
| node-version: [18, 20] | |||
| os: [ubuntu-latest, macos-latest, windows-2019] | |||
| runs-on: ${{ matrix.os }} | |||
| defaults: | |||
| run: | |||
| shell: bash | |||
There was a problem hiding this comment.
It needs to be specified, since by default it launches Powershell on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Sometimes initialising git repository fails, because machine doesn't have git installed or configured correctly so when running E2E tests we need to take this into account and dynamically assign files that we're expecting.
Test Plan:
CI
Checklist