Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not ask for port change when --no-packager provided #2128

Merged
merged 3 commits into from
Oct 27, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Hides prompt when port is busy when provided --no-packager flag.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Start packager in other app on 8081 port
  3. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios --no-packager

Shouldn't prompt for port change.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
Copy link
Collaborator Author

cc. @huntie

@thymikee thymikee merged commit dc9ef03 into main Oct 27, 2023
@thymikee thymikee deleted the fix/do-not-ask-for-port-change-when-no-packager branch October 27, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants