Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: skip pods installation when it's already installed #2112

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix: skip pods installation when it's already installed #2112

merged 1 commit into from
Oct 19, 2023

Conversation

TMisiukiewicz
Copy link
Collaborator

@TMisiukiewicz TMisiukiewicz commented Oct 10, 2023 •
edited
Loading

Summary:

Skip pods installation in run-ios and build-ios if they were installed manually before

Test Plan:

  1. Init new project
  2. Go to ios and run pod install
  3. Use run-ios and verify pods are not installed
  4. Add new package containing native code, e.g. react-native-gesture-handler
  5. Use run-ios again and verify pods are installed
  6. Init new project
  7. Use run-ios and verify pods are installed

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@TMisiukiewicz TMisiukiewicz marked this pull request as ready for review October 11, 2023 06:25
szymonrybczak
szymonrybczak approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thymikee thymikee merged commit abe0d1e into react-native-community:main Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz

@thymikee thymikee Awaiting requested review from thymikee

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TMisiukiewicz @szymonrybczak @thymikee