Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: delete useless mocking in e2e tests #2103

Merged
merged 2 commits into from
Oct 25, 2023
Merged

fix: delete useless mocking in e2e tests #2103

merged 2 commits into from
Oct 25, 2023

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Oct 9, 2023 •
edited
Loading

Summary:

Mocking prompts doesn't change anything if we're running command in real world scenario with runCLI function.

Test Plan:

CI Green.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the bugfix label Oct 9, 2023
@szymonrybczak szymonrybczak merged commit 28a75d5 into main Oct 25, 2023
@szymonrybczak szymonrybczak deleted the fix/delete-useless-mocking-promptsa branch October 25, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamTrz adamTrz adamTrz approved these changes

@thymikee thymikee Awaiting requested review from thymikee thymikee is a code owner

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@szymonrybczak @adamTrz