Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ios): check if there are any available simulators or physical devices #2102

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

In this PR I added condition which check if there are any simulators / physical devices available.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Uninstall simulators and unpair physical devices
  3. Command xcrun xcdevice list should list only your computer
  4. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js run-ios

It should give an error.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@szymonrybczak
Copy link
Collaborator Author

Tests passing locally, changes not related to failure. I don't know why recently there's so much flakiness problems around these E2E tests.

@szymonrybczak szymonrybczak changed the title fix: check if there are any available simulators / physical devices fix(ios): check if there are any available simulators or physical devices Oct 8, 2023
@szymonrybczak szymonrybczak mentioned this pull request Oct 10, 2023
2 tasks
@thymikee thymikee merged commit 4d149bc into main Oct 31, 2023
@thymikee thymikee deleted the fix/check-if-are-any-avaliable-destinations branch October 31, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants