Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add 'code-insiders' to launchEditor #2092

Conversation

joshuayoes
Copy link
Contributor

@joshuayoes joshuayoes commented Sep 29, 2023

Summary:

Visual Studio Code Insiders has a seperate editor name than Visual Studio Code, but has the same signature, so this PR adds 'code-insiders' to getArgumentsForLineNumber

Test Plan:

  1. Install https://code.visualstudio.com/insiders/
  2. Run > Shell Command: Install 'code-insiders' command in PATH in command pallet
  3. Change $REACT_EDITOR to 'code-insiders'
  4. Throw an error in development of a react-native cli app.
  5. Click on the logbox error.
  6. See that error is opened
Add.code-insiders.to.launchEditor.mov

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙌 Works great!

Visual Studio Code Insiders has a seperate editor name than Visual Studio Code, but has the same signature, so this PR adds 'code-insiders' to getArgumentsForLineNumber
@szymonrybczak szymonrybczak force-pushed the fix/launch-editor-code-insiders branch from f6b1109 to 8c18af7 Compare October 3, 2023 15:34
@szymonrybczak
Copy link
Collaborator

Rebased because we landed a fix for flakiness on main, CI should be green right now.

@thymikee thymikee merged commit 402a5be into react-native-community:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants