fix: Creating cache for scoped packages #2089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
If
package.json
had scoped package name, e.g.@react-native/tester
, it was unable to create CLI cache sincefs.writeFileSync
could not create it in a path that does not exist. With this PR it will recursively create necessary folder for scoped packages before trying to save the cache file.Test Plan:
node ./path/to/cli init AppName
yarn ios
and make sure app runs correctlyname
inpackage.json
to@react-native/tester
yarn ios
and make sure app runs correctly~/Library/Caches/react-native-cli/@react-native
folder and make suretester
file existsChecklist