Do not attempt to search for manifest in test folders #2075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 12, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Differential Revision: D49190626 fbshipit-source-id: 26fcdb13147f992451d428a9b8dd886c0cb5bfd5
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 12, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 13, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 13, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
szymonrybczak
approved these changes
Sep 13, 2023
|
This exclude list is getting out of hand 😅 |
|
@thymikee I also think that if more than one manifest is found, we should not just pick the first as that's not necessarily the right pick |
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Sep 13, 2023
Summary: `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 13, 2023
Summary: Pull Request resolved: #39413 `yarn android` on main is currently broken due to the CLI attempting to search for the manifest inside the src/androidTest folder. This fixes it by specifying the exact path of the Android Manifest. The fix to the CLI is also pending to prevent the CLI from searching inside test folders. Fix for the CLI is here: - react-native-community/cli#2075 Changelog: [Internal] [Changed] - Unblock `yarn android` on main Reviewed By: huntie Differential Revision: D49190626 fbshipit-source-id: 99309f17cb08a33be2a565f5faa29130862686ea
|
Maybe prompting the user which one to pick and adjust the configuration accordingly to avoid prompting again? |
Maybe that's a bit overcomplicated. In general the manifest inside |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The CLI should not attempt to look into test folders to grab manifests from there.
Specifically this is broken in the
react-nativerepo as we do have those two Manifests:With this change we prevent the CLI from searching inside
src/test/andsrc/androidTest.Test Plan:
I've tested this on
mainofreact-nativeandyarn androidnow works well.Checklist