Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adjust wording for dev server port taken messages #2067

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Sep 8, 2023

Summary

Simplifies "port taken" messages to replace [packager|Metro|Metro Bundler] with "dev server", matching recent changes in @react-native/community-cli-plugin.

@@ -18,11 +15,13 @@ export const askForPortChange = async (port: number, nextPort: number) => {
};

export const logAlreadyRunningBundler = (port: number) => {
logger.info(`Metro Bundler is already for this project on port ${port}.`);
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Fixes typo!

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@thymikee thymikee merged commit 45c868f into react-native-community:main Sep 11, 2023
6 checks passed
@huntie huntie deleted the debugging-cleanup-3 branch September 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants