Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: Remove unreferenced utils from cli-tools #2066

Merged
merged 1 commit into from
Sep 11, 2023
Merged

breaking: Remove unreferenced utils from cli-tools #2066

merged 1 commit into from
Sep 11, 2023

Conversation

huntie
Copy link
Collaborator

@huntie huntie commented Sep 8, 2023

Summary

Removes the getPidFromPort and hookStdout exports from cli-tools. These are no longer referenced in community-cli-plugin (formerly cli-plugin-metro) since facebook/react-native#39078.

Test plan

tsc

szymonrybczak
szymonrybczak approved these changes Sep 10, 2023
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for cleanup! 👍

@thymikee thymikee merged commit bae48a7 into react-native-community:main Sep 11, 2023
6 checks passed
@huntie huntie deleted the debugging-cleanup-2 branch September 11, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymonrybczak szymonrybczak szymonrybczak approved these changes

@adamTrz adamTrz Awaiting requested review from adamTrz adamTrz is a code owner

@thymikee thymikee Awaiting requested review from thymikee thymikee is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huntie @szymonrybczak @thymikee