Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install template dev dependencies as such #202

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

emin93
Copy link
Member

@emin93 emin93 commented Mar 5, 2019

Hi everyone,

This pull request contains a small fix for the issue that caused template dev dependencies to be installed as regular dependencies.

Test Plan:

Went with the guide in the CONTRIBUTION.md document, installed Verdaccio, released a new version of React Native to it and used it to create a new project with a template that has dev dependencies to check if the dependencies are still being installed as regular dependencies.

fixed issue that caused dev dependencies to be installed as regular dependencies
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks you 🙂

@thymikee thymikee requested a review from Esemesek March 5, 2019 10:57
@emin93 emin93 changed the title fix: Template dev dependencies are now being installed as such fix: install template dev dependencies as such Mar 5, 2019
@grabbou grabbou merged commit 75c86c8 into react-native-community:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants