Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: sync status with current state of upgrade command #1994

Conversation

szymonrybczak
Copy link
Collaborator

Summary:

Related: #1879

Test Plan:

n/a

@github-actions github-actions bot added the docs Documentation change label Jul 3, 2023
@szymonrybczak
Copy link
Collaborator Author

@thymikee WDYT about adding to the PR's template note "Make sure to check if your changes affected docs, if yes please sync them with current state"? This will probably avoid situations like this one.

docs/commands.md Outdated Show resolved Hide resolved
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also good with updating the PR template. Doubt if it improves things in this area, but why not

@thymikee thymikee merged commit 1c04cbd into react-native-community:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants