feat: remove hacky check for faulty global react-native installation #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This check was always hacky, got a lot of false-positives and it seems to cause more bad than good. We never encourage people to install
react-nativeglobally (justreact-native-cli, but that will change soon), and CLI binary shouldn't be blocked by the fact that somebody run it in a different way – e.g. throughnpx.This unblocks
npx react-native init Appcommand, that @Esemesek is working on.Fixes #197
Test Plan:
Running CLI locally works regardless of where and how it's called.
cc @grabbou this should also make it easier to work in RNTester.