Reintroduce tvOS as valid simulator version when matching for simulators #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
approved these changes
May 5, 2023
Will do! Need to figure out how we handle such regression tests though in the test suite :). |
|
We could bring back this test case: https://github.com/react-native-community/cli/pull/1823/files#diff-27e264720294944fa63844f5cb36f8eeb5c6575176725a4823f80189fcb3020fL891 |
Done 🚀 ! |
|
@douglowder sure, I think that's doable. However, is it the 9.x? Because RN 0.71 is tied to CLI v10.x. |
|
Oops sorry, yes that would be 10.x, thanks :) |
thymikee
pushed a commit
that referenced
this pull request
Jun 15, 2023
…ors (#1929) * reintroduce tvOS as valid target when matching simulators * reintroduce matching of Apple TV devices test
|
@douglowder released in 10.2.5 |
douglowder
added a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Jun 19, 2023
- Includes Apple TV fix react-native-community/cli#1929
douglowder
added a commit
to react-native-tvos/react-native-tvos
that referenced
this pull request
Jun 19, 2023
- Includes Apple TV fix react-native-community/cli#1929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request should close issue #1927. It was caused by being too rigid when it comes to filtering out versions while searching for a valid simulator. This PR reintroduces
tvOSas a valid version on this code path. @adamTrz is there a reason why it has been removed in the first place?Test Plan:
yarn ioscommand with--simulatorset asApple TV.yarn ios --simulator "iPhone 14 Pro"or not specific simulator at allyarn ios. It should still run.