fix : Getting rid of stack traces during run-ios
by using CLIError
#1892
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As highlighted in #1766, there are useless stack traces in errors during
run-ios
that are meant to be human-readable. Hence utilizing CLIError of it's ability to strip out the stack trace in such cases.In case we are not able to find the simulators in Xcode, the error is direct and message is sufficient, hence removing the stack trace in such case to improve error reporting. This workflow is part of the onboarding experience of RN, there by this would improve DevX
Test Plan:
node ./scripts/build.js && yarn build:debugger
.cd packages/cli-platform-ios
yarn link
AwesomeProject
, runyarn link "@react-native-community/cli-platform-ios"
to see successful linking :react-native run-ios