Breaking: Remove androidMkPath from react-native config #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
approved these changes
Feb 20, 2023
|
As long as it's surfaced in the RN 0.72 release notes, I'm good with doing this now 👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I'm proposing we remove the
androidMkPathfield fromreact-native configand from the autolinking.Since 0.70 we now fully support CMake for build configuration, and the
Android.mkfiles have been removed from the default template.I'm not aware of anyone relying on the autolinking generating
Android.mkfiles for them + it seems like no one is using this field anymore:https://cs.github.com/?scopeName=All+repos&scope=&q=androidMkPath+path%3A*.js
(As the fields had a sensible default, and it was unlikely libraries had to override this).
Deprecation Plan:
If we feel this is too 'aggressive', we can keep
androidMkPathinside the CLI for one version, so that apps on 0.72 will keep on using it for the fallback behaviour forcmakeListsPathand eventually remove in 0.73.