fix: avoid considering the Podfile in vendor/bundle/ruby folder as a possibly valid Podfile #1827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…possibly valid Podfile
Titozzz
approved these changes
Feb 10, 2023
adamTrz
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR should fix a problem connected with bundle for which, when we run
bundle exec pod installin a React Native app, the CLI founds two Podfiles.This is the output before the change:
And this is the output after the change:
Test Plan:
Tested manually in a new RN project, by changing the code in
@react-native-community/cli-platform-ios/build/config/findPodfilePath.