-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add build-ios
command
#1744
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamTrz
reviewed
Nov 14, 2022
docs/commands.md
Outdated
|
||
#### Options | ||
|
||
#### `--mode <release|debug>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use --configuration
instead of --mode
, because --mode
doesn't exist.
Suggested change
#### `--mode <release|debug>` | |
#### `--configuration <release|debug>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MateWW
force-pushed
the
feat/build-ios
branch
from
November 16, 2022 15:19
53a7590
to
8d97639
Compare
MateWW
requested review from
szymonrybczak and
adamTrz
and removed request for
thymikee,
szymonrybczak and
adamTrz
November 16, 2022 15:30
cc @cipolleschi if you want to have a look here |
adamTrz
reviewed
Nov 24, 2022
MateWW
force-pushed
the
feat/build-ios
branch
from
November 28, 2022 13:36
578a2e6
to
2f3f7c0
Compare
MateWW
requested review from
szymonrybczak and
adamTrz
and removed request for
szymonrybczak
December 5, 2022 11:44
adamTrz
reviewed
Dec 7, 2022
packages/cli-platform-ios/src/commands/buildIOS/buildProject.ts
Outdated
Show resolved
Hide resolved
TMisiukiewicz
approved these changes
Jan 24, 2023
adamTrz
approved these changes
Jan 25, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As a follow-up to #1739 I've created
build-ios
command.Besides that, I've refactored run-ios to share parts used in both commands
Test Plan:
react-native init
yarn react-native build-ios