Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add build-ios command #1744

Merged
merged 15 commits into from
Jan 25, 2023
Merged

Conversation

MateWW
Copy link
Contributor

@MateWW MateWW commented Nov 9, 2022

Summary:

As a follow-up to #1739 I've created build-ios command.
Besides that, I've refactored run-ios to share parts used in both commands

Test Plan:

  • crate app with react-native init
  • link CLI
  • run yarn react-native build-ios

docs/commands.md Outdated

#### Options

#### `--mode <release|debug>`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use --configuration instead of --mode, because --mode doesn't exist.

Suggested change
#### `--mode <release|debug>`
#### `--configuration <release|debug>`

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually that was kinda requested feature to unify naming convention when building / running the app with custom params for both platforms.
You can read a bit more here: #1128 and here: #179

@cortinico
Copy link
Member

cc @cipolleschi if you want to have a look here

docs/commands.md Outdated Show resolved Hide resolved
@MateWW MateWW requested review from adamTrz and removed request for adamTrz December 5, 2022 11:44
@MateWW MateWW requested review from szymonrybczak and adamTrz and removed request for szymonrybczak December 5, 2022 11:44
@github-actions github-actions bot added docs Documentation change feature labels Jan 24, 2023
@adamTrz adamTrz merged commit e932dd6 into react-native-community:main Jan 25, 2023
@thymikee thymikee changed the title feat: build-ios command feat: add build-ios command Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation change feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants