fix: avoid catching init errors and avoid printing their stack
#1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
changed the title
init errors and avoid printing their stackinit errors and avoid printing their stack
|
I fixed the failing e2e test. |
kraenhansen
commented
Nov 6, 2022
| @@ -204,6 +204,8 @@ ${chalk.bold('args:')} ${(args || []).join(' ')} | |||
| ${chalk.bold('stderr:')} ${result.stderr} | |||
| ${chalk.bold('stdout:')} ${result.stdout} | |||
| ${chalk.bold('code:')} ${result.code}`); | |||
| } else if (options.expectedFailure && result.code === 0) { | |||
| throw new Error("Expected command to fail, but it didn't"); | |||
There was a problem hiding this comment.
This could have caught this (or a similar issue) earlier.
thymikee
pushed a commit
that referenced
this pull request
Nov 8, 2022
* Defer from "init" to index.ts to handle errors * Extend a CLIError to avoid printing stack * Fixing tests by relaxing the stderr match * Assert non-zero exit code if failure is expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
I experienced the following issue: #1741 and decided to fix it too.
I've made four changes:
handleErrorinsrc/index.ts.CLIErrorto avoid printing the stack, since "we know exactly what went wrong" and expects the user to have the means to fix it.\nin the stderr)jest/helpers.ts'shandleTestFailureto assert a non-zero exit code if expectedFailure is true. This could have caught this (or a similar issue) earlier.Test Plan:
I suggest following the instructions for reproducing this on the original issue, only this time, notice how the command exits with status code 1 as expected and it still doesn't print the error stack.