Add support for namespace inside build.gradle file. #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the support for getting the Android package from the `namespace` field inside the build.gradle file. Starting from the recent version of AGP, users should use namespace to setup the package rather than AndroidManifest.xml Not doing this, is causing this warning on new apps on console: ``` package="com.androidtemplateproject" found in source AndroidManifest.xml: /tmp/AndroidTemplateProject/android/app/src/main/AndroidManifest.xml. Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated. Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information. ``` This commit allows user to setup the namespace inside the build.gradle to suppress this resolve this warning and still being able to build.
cortinico
requested review from
grabbou,
thymikee and
Esemesek
as code owners
This was referenced Oct 27, 2022
adamTrz
approved these changes
Oct 27, 2022
|
@adamTrz Can we get a new alpha release with this commit included? |
|
how to use this fix if react-native 0.70.5 is using @react-native-community/cli 9.2.1? |
|
hi @chenop this PR was shipped with v10.0.0 of the CLI, so updating to the newest version should help you |
|
We could backport this to v9 and issue another release of 0.70.x if that makes sense, I'm just not sure if it does. cc @kelset |
|
I'm fine either way, but that'd likely mean also a 0.70.x patch and I'm not sure we're planning on making one... we'll figure out later this week I guess. cc @cortinico any opinions? |
So this could technically be backported, as it's fully backward compatible. It's probably good to backport, as we'd like libraries to migrate to use On the other hand, the impact of this is just a warning for now so not super urgent. |
thymikee
pushed a commit
that referenced
this pull request
Jul 17, 2023
This commit introduces the support for getting the Android package from the `namespace` field inside the build.gradle file. Starting from the recent version of AGP, users should use namespace to setup the package rather than AndroidManifest.xml Not doing this, is causing this warning on new apps on console: ``` package="com.androidtemplateproject" found in source AndroidManifest.xml: /tmp/AndroidTemplateProject/android/app/src/main/AndroidManifest.xml. Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated. Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: https://developer.android.com/studio/build/configure-app-module#set-namespace This migration can be done automatically using the AGP Upgrade Assistant, please refer to https://developer.android.com/studio/build/agp-upgrade-assistant for more information. ``` This commit allows user to setup the namespace inside the build.gradle to suppress this resolve this warning and still being able to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This commit introduces the support for getting the Android package from the
namespacefield inside the build.gradle file.Starting from the recent version of AGP, users should use namespace to setup the package rather than AndroidManifest.xml
Not doing this, is causing this warning on new apps on console:
This commit allows user to setup the namespace inside the build.gradle to suppress this resolve this warning and still being able to build.
Fixes: #1721
Also related to facebook/react-native#35094
Test Plan:
I've wrote Jest tests for this + for also the package parsing which were missing.