feat(ios): use Bundler for pods installation #1708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cipolleschi
approved these changes
Oct 4, 2022
|
|
||
| async function runBundleInstall(loader: Loader) { | ||
| try { | ||
| loader.start('Installing Bundler'); |
There was a problem hiding this comment.
Why this line does not appear in the successful run posted in the Test Plan? 🤔
There was a problem hiding this comment.
Why this line does not appear in the successful run posted in the Test Plan? 🤔
Looks like I need to make a separate loader.succeed call, will fix that
| logger.error(error.stderr || error.stdout); | ||
|
|
||
| throw new Error( | ||
| 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart for macOS and iOS.', |
There was a problem hiding this comment.
nit
Suggested change
| 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart for macOS and iOS.', | |
| 'Looks like your iOS environment is not properly set. Please go to https://reactnative.dev/docs/next/environment-setup and follow the React Native CLI QuickStart guide for macOS and iOS.', |
hoxyq
force-pushed
the
use-bundler-for-cocoapods
branch
from
92a2d5c to
40dccc4
Compare
|
Updated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Test Plan:
yarn test