[android] Do not separate autolinked libraries with \ on CMake #1661
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Autolinking for New Architecture, on Android, with CMake, with more than 1 library is currently broken. The reason is that the library list is separated by
\
(as it was supposed to be for Android.mk) that are not a valid char for CMake (see https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#cmake-language-lists for reference).Test Plan:
I've tested this against https://github.com/react-native-community/RNNewArchitectureApp.
Before:
After: