-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(clean, cocoapods): clean spec cache + installed Pods #1620
Conversation
as documented in reactnative.dev, fixes java 8 build fail
distribution: 'zulu' | ||
java-version: 11 | ||
cache: 'gradle' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
config guide for quick cross-check if desired https://github.com/actions/setup-java#caching-gradle-dependencies
- they use the single quotes around strings, that's best practice in YAML
- zulu is the name they use for the JDK series that corresponds to current react native guide https://reactnative.dev/docs/environment-setup
@@ -46,11 +46,11 @@ jobs: | |||
runs-on: ${{ matrix.os }} | |||
steps: | |||
- uses: actions/checkout@v2 | |||
- uses: actions/setup-java@v2 | |||
- uses: actions/setup-java@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3 is current (well, v3.3.0 is, but they move the v3 tag along with releases) https://github.com/actions/setup-java/tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I guess I got used to it. Thank you for tackling this @mikehardy 🙇🏼♂️ |
Summary:
I just saw that the CLI has a new clean command. That's fantastic!
Historically I steer people to https://github.com/pmadruga/react-native-clean-project but really it's basic functionality, glad to see it in the CLI.
I had a problem that I PRd to react-native-clean-project regarding cocoapods spec cache poisoning, and install / unpack failures, and they were solved by also cleaning
~/.cocoapods
and cleaningios/Pods
so I am PR'ing that hereI understand paths might be an issue but since we are inside an
os === darwin
conditional, the~/
should be okay. I'm not sure about theios/
though and will happily take guidanceTest Plan:
In practice for a long time, here:
https://github.com/pmadruga/react-native-clean-project/blob/65c012ed0dcf4ea6786af867e8a7b1c1ee00be86/source/internals/tasks.js#L8-L22