feat(perf): use lazy module evaluation #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
feat/inline-requires
branch
from
972bbe3
to
704f0f6
Compare
|
This is so good! We got from around 2.5s to 0.2s over two weeks. Can't wait to ship it to React Native developers! |
grabbou
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
After #150 (thanks @sidferreira and @Trancever) we're finally able to use lazy module evaluation for additional perf!
Before:
After:
Which gives us roughly 0.5s (~72%) improvement in startup time. With 0.2s startup time most commands feel instant now.
Test Plan:
No new tests added.