fix: improve overall run-ios experience and get rid of CFBundleIdentifier #139
Conversation
|
Nice work! 👏
Cool, so this will prevent us to have a |
packages/cli/src/util/logger.js
Outdated
| const debug = (...messages: Array<string>) => { | ||
| console.log(`${chalk.black.bgWhite(' DEBUG ')} ${joinMessages(messages)}`); | ||
| }; | ||
|
|
||
| class ProcessError extends Error { |
There was a problem hiding this comment.
This doesn't belong to logger. Can you move it to some kind of errorHelpers?
There was a problem hiding this comment.
Yup, good idea. I'd suggest "errors" for now.
| errorOutput | ||
| ) | ||
| ); | ||
| return; |
There was a problem hiding this comment.
is this return necessary after we rejected?
There was a problem hiding this comment.
It's not - just my personal preference of early returns over /else clause (visual appearance).
There was a problem hiding this comment.
I think I'll update it to if/else here 👌
|
Check @thymikee if you are happy with the last commit and if yes, let's merge it 🔥 |
|
|
||
| class ProcessError extends Error { | ||
| constructor(msg: string, processError: string) { | ||
| super(`${chalk.red(msg)}\n\n${chalk.gray(processError)}`); |
There was a problem hiding this comment.
Looks silly, but I'm cool with that :)
There was a problem hiding this comment.
I would say it's a "temporary" solution when we figure out proper logging. I think it's a good starting point.
|
I follow the issue " ":CFBundleIdentifier", Does Not Exist"to here, and this issue is still exist🙁 |
|
Please note this is only available since RN 0.59 which is still in RC period. Your project uses 0.57. |
Fixes #107
Summary:
Bugs fixed:
Changes made:
Test Plan:
Here's how the error messages look before/now:
While try to build a project with a wrong "schema" :
Before:
After:
While building a project that has a typo in "AppDelegate.m":
Before:
After:
You can try it out by running
run-ioscommand on a broken project (typo, wrong configuration) or by passing a non-existingschema