Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs note about option.name version #1301

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

Grohden
Copy link
Contributor

@Grohden Grohden commented Oct 22, 2020

Summary:

As discussed in #1300 I've added a simple note about the usage of the word --version for options.name to warn future plugin writers about that specific case

This closes #1300

Added a note about `options.name` reserved word `--version`, commanderjs doesn't work as expected with this specific flag
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect

@thymikee thymikee merged commit 12315f2 into react-native-community:master Oct 24, 2020
@Grohden Grohden deleted the patch-1 branch October 24, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version flag is passed as function for plugin args
2 participants