Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "core" to a separate package, such as "cli-tools" #49

Closed
grabbou opened this issue Dec 15, 2018 · 2 comments
Closed

Move "core" to a separate package, such as "cli-tools" #49

grabbou opened this issue Dec 15, 2018 · 2 comments

Comments

@grabbou
Copy link
Member

grabbou commented Dec 15, 2018

The local-cli/core is not really a core, it's just a set of useful "tools" that can be used to locate iOS project somewhere etc.

In order to make it easy for other plugins and packages to use this, we should definitely make it a separate package with public interface.

Right now, some developers are requiring them directly from "build" or "src" folder, which is dangerous.

@gengjiawen
Copy link
Member

Some features I love to have:

  • Like add util wait for emulator online. Make it easier for android to do instrumentation test.

@grabbou
Copy link
Member Author

grabbou commented Jan 16, 2019

CC: @fson - this is definitely area for us to discuss

Esemesek pushed a commit that referenced this issue Mar 5, 2019
Summary:
---------

Cleaning up the `packages/cli` structure. This might be pretty disruptive to already open PRs :D.

- Renamed `core` -> `tools`
- Moved `util` to `tools`
- Flatten-out `server/util`
- Create `commands` dir and put all commands there

```
packages/cli/src
├── bin.js
├── cliEntry.js
├── commands
│   ├── bundle
│   ├── dependencies
│   ├── eject
│   ├── index.js
│   ├── info
│   ├── init
│   ├── install
│   ├── library
│   ├── link
│   ├── logAndroid
│   ├── logIOS
│   ├── runAndroid
│   ├── runIOS
│   ├── server
│   └── upgrade
├── index.js
└── tools
    ├── ...
``` 

Fixes #49

Test Plan:
----------

CI green
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants