Skip to content

Commit

Permalink
fix(ios): fix Xcode defaulting to 'Release' (#1957)
Browse files Browse the repository at this point in the history
`getBuildConfigurationFromXcScheme` currently assumes where the
`.xcodeproj` lives (it could be anywhere). The proper fix is to get the
path from `.xcworkspace`, but that's a much more intrusive change. The
least we can do for now is to fall back to `Debug`.
  • Loading branch information
tido64 authored and thymikee committed Jun 12, 2023
1 parent c878c39 commit eb225ee
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions packages/cli-platform-ios/src/tools/getConfigurationScheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@ export function getConfigurationScheme(
) {
if (scheme && mode) {
return mode;
} else if (scheme) {
return getBuildConfigurationFromXcScheme(scheme, mode, sourceDir);
}

return mode || 'Debug';
const configuration = mode || 'Debug';
if (scheme) {
return getBuildConfigurationFromXcScheme(scheme, configuration, sourceDir);
}

return configuration;
}

0 comments on commit eb225ee

Please sign in to comment.