Error reporting in run-android (#1891)

Co-authored-by: Arushi Kesarwani <arushikesarwani@meta.com>
react-native-community · Mar 27, 2023 · abbec76 · abbec76
1 parent 917f1bf
commit abbec76
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts b/packages/cli-platform-android/src/commands/runAndroid/runOnAllDevices.ts
@@ -139,7 +139,10 @@ function createInstallError(error: Error & {stderr: string}) {
     )}."`;
   }
 
-  return new CLIError(`Failed to install the app. ${message}`, error);
+  return new CLIError(
+    `Failed to install the app. ${message}`,
+    message.length > 0 ? undefined : error,
+  );
 }
 
 export default runOnAllDevices;
diff --git a/packages/cli-platform-android/src/config/index.ts b/packages/cli-platform-android/src/config/index.ts
@@ -21,6 +21,7 @@ import {getPackageName} from './getAndroidProject';
 import {findLibraryName} from './findLibraryName';
 import {findComponentDescriptors} from './findComponentDescriptors';
 import {findBuildGradle} from './findBuildGradle';
+import {CLIError} from '@react-native-community/cli-tools';
 
 /**
  * Gets android project config by analyzing given folder and taking some
@@ -53,7 +54,7 @@ export function projectConfig(
     userConfig.packageName || getPackageName(manifestPath, buildGradlePath);
 
   if (!packageName) {
-    throw new Error(
+    throw new CLIError(
       `Package name not found in neither ${manifestPath} nor ${buildGradlePath}`,
     );
   }