fix: Workaround JSON.stringify failing on large arrays with the error…

… "RangeError: Invalid string length" when downloading profiling (#2050)
react-native-community · Aug 8, 2023 · 1427136 · 1427136
1 parent 7165558
commit 1427136
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/cli-hermes/src/profileHermes/downloadProfile.ts b/packages/cli-hermes/src/profileHermes/downloadProfile.ts
@@ -123,9 +123,14 @@ export async function downloadProfile(
         file,
         '.cpuprofile',
       )}-converted.json`;
+
+      // Convert to JSON in chunks because JSON.stringify() will fail for large
+      // arrays with the error "RangeError: Invalid string length"
+      const out = events.map(JSON.stringify).join(",");
+
       fs.writeFileSync(
         transformedFilePath,
-        JSON.stringify(events, undefined, 4),
+        "["+out+"]",
         'utf-8',
       );
       logger.success(