chore: Improve releases #711
Conversation
| "@semantic-release/git", | ||
| { | ||
| "assets": ["CHANGELOG.md", "package.json"], | ||
| "message": "chore(release): ${nextRelease.version} [skip ci]" |
There was a problem hiding this comment.
GitHub Actions does not understand skip ci by default. We need to manually check for it. You can have a look at how it was done in react-native-test-app: microsoft/react-native-test-app@c20eaaa
There was a problem hiding this comment.
Never mind. It looks like it was added earlier this year: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/
There was a problem hiding this comment.
good one, will apply that never mind then 👍
| @@ -92,7 +94,7 @@ | |||
| "react-native-web": "~0.12.0", | |||
| "react-native-windows": "^0.63.41", | |||
| "react-test-renderer": "16.13.1", | |||
| "semantic-release": "^17.2.1" | |||
| "semantic-release": "^17.4.6" | |||
There was a problem hiding this comment.
I did not bump to latest due to node version required (14), while our CI images are at 12
There was a problem hiding this comment.
Should we bump Node to 14 (in a separate PR)?
There was a problem hiding this comment.
Yes, that'd require more compatibility checks on CI, so ideally separate PR
| "@semantic-release/changelog": "^5.0.1", | ||
| "@semantic-release/git": "9.0.0", |
There was a problem hiding this comment.
| "@semantic-release/changelog": "^5.0.1", | |
| "@semantic-release/git": "9.0.0", | |
| "@semantic-release/changelog": "^6.0.1", | |
| "@semantic-release/git": "^10.0.1", |
There was a problem hiding this comment.
Same as above, those require node 14
| @@ -40,7 +40,7 @@ default config for android apk builds: &android_defaults | |||
| resource_class: 'medium' | |||
| working_directory: ~/async_storage | |||
| environment: | |||
| - _JAVA_OPTIONS: '-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -Xmx2048m' | |||
There was a problem hiding this comment.
Apparently this was never needed
https://stackoverflow.com/a/52555836/3510245
* improve releases * remove java automatic heap detection
|
🎉 This PR is included in version 1.15.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary