-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add type definition for jest mock #708
chore: add type definition for jest mock #708
Conversation
@krizzu please review this PR. It seems that you're the maintainer. |
Sure thing, looks fine I just wonder if we can reduce the duplication and do something like this
|
@krizzu Thanks for review! It seems like some internal error in Android testing, but I have no permission for rerunning CI tests. Can you rerun that CI test? |
@lafest Hey, please rebase your code, we merged a fix for this yesterday |
* improve releases * remove java automatic heap detection
@krizzu I rebased this repository's master branch to mine. I'm not sure I did right thing, because this is my first rebase. Did I do right? |
It's more like a merge, than a rebase, but it's fine. @tido64 mind having a look at the types? Need another pair of eyes on this 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the merge/rebase weirdness, it looks fine to me.
🎉 This PR is included in version 1.15.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
According to with-jest-setup-file jest integration, I tried to test
app.test.tsx
file using ts-jest and followedthrows ts(7016) error.
Test Plan
If you use this change with ts-jest, the error disappears.