-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: native validation with inputs array #329
Conversation
Size Change: +146 B (+1%) Total Size: 23.7 kB
ℹ️ View Unchanged
|
905fec0
to
a69afcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
const setCustomValidity = (ref: Ref, fieldPath: string, errors: Record<string, FieldError>) => { | ||
if (ref && 'reportValidity' in ref) { | ||
const error = get(errors, fieldPath) as FieldError | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you need the cast
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, get
returns any
🎉 This PR is included in version 2.8.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.