Allow clear dates to clear partially entered dates #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Jun 10, 2017
ljharb
added
the
semver-major: breaking change
|
Agreed, I couldn't think of anything better that differentiated from the existing variable |
timhwang21
force-pushed
the
timhwang21/525-clear-partial-dates
branch
from
b79eea1
to
b6d1408
Compare
timhwang21
force-pushed
the
timhwang21/525-clear-partial-dates
branch
from
8eb1ebd
to
0ab40c2
Compare
Addresses react-dates#525. Move user input state out of `<DateInput/>` and into either `<DateRangePickerInputController/>` or `<SingleDatePicker/>`, passing down the value and a setter as props.
timhwang21
force-pushed
the
timhwang21/525-clear-partial-dates
branch
from
0ab40c2
to
e10c0a7
Compare
|
We are running into #525 and would love to have this change merged. Is there any reason we're holding on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #525.
Move user input state out of
<DateInput/>and into either<DateRangePickerInputController/>or<SingleDatePicker/>, passing down the value and a setter as props.