chore: fix prevValue to be empty string if not defined

react-component · Sep 29, 2024 · 81e3375 · 81e3375
1 parent 296327d
commit 81e3375
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/src/InputNumber.tsx b/src/InputNumber.tsx
@@ -206,7 +206,7 @@ const InternalInputNumber = React.forwardRef(
         const numStr = String(num);
 
         if (parser) {
-          return parser(numStr, { prevValue: String(prevValueRef.current) });
+          return parser(numStr, { prevValue: String(prevValueRef.current ?? '') });
         }
 
         let parsedStr = numStr;
@@ -227,7 +227,7 @@ const InternalInputNumber = React.forwardRef(
           return formatter(number, {
             userTyping,
             input: String(inputValueRef.current),
-            prevValue: String(prevValueRef.current),
+            prevValue: String(prevValueRef.current ?? ''),
           });
         }
 
@@ -389,10 +389,9 @@ const InternalInputNumber = React.forwardRef(
 
     // >>> Collect input value
     const collectInputValue = (inputStr: string) => {
-
       // validate string
-      if(validator){
-        if(!validator(inputStr)) return;
+      if (validator) {
+        if (!validator(inputStr)) return;
       }
 
       recordCursor();

diff --git a/tests/formatter.test.tsx b/tests/formatter.test.tsx
@@ -163,7 +163,7 @@ describe('InputNumber.Formatter', () => {
 
     fireEvent.change(container.querySelector('input'), { target: { value: '1' } });
     expect(formatter).toHaveBeenCalledTimes(1);
-    expect(formatter).toHaveBeenCalledWith('1', { userTyping: true, input: '1' });
+    expect(formatter).toHaveBeenCalledWith('1', { userTyping: true, input: '1', prevValue: '' });
   });
 
   describe('dynamic formatter', () => {