Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SizePerPage dropdown reserves space even if not present #236

Open
waynebrantley opened this issue Mar 5, 2018 · 5 comments
Open

SizePerPage dropdown reserves space even if not present #236

waynebrantley opened this issue Mar 5, 2018 · 5 comments

Comments

@waynebrantley
Copy link

Similar to this issue:
AllenFang/react-bootstrap-table#1818

The size per page drown reserves space as it outputs
<div class="col-md-6 col-xs-6 col-sm-6 col-lg-6"></div> even if hidden (which makes the buttons be too far over to the right)

sizePerPageList.length > 1 && !hideSizePerPage ?

should be moved up to this
<div className="col-md-6 col-xs-6 col-sm-6 col-lg-6">

@AllenFang
Copy link
Member

@waynebrantley understand. I will tweak this DOM structure. thanks

@ertejaspatel
Copy link

Hi

Is there any update on fixing this one?

Thanks

@Totollie
Copy link

+1, I've just come across this issue, is there any update on a correction for this?

@humayunkabir
Copy link

Hello,
I want to fix this issue. The class col-xs-6 used in this code is not even a Bootstrap 4 class. How to contribute here. I am new in open source.

@justinjamesp1988
Copy link

standalone dropdown not keyboard accessible ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants