Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SizePerPage dropdown reserves space even if not present #1818

Closed
waynebrantley opened this issue Dec 18, 2017 · 1 comment
Closed

SizePerPage dropdown reserves space even if not present #1818

waynebrantley opened this issue Dec 18, 2017 · 1 comment

Comments

@waynebrantley
Copy link

When the sizePerPage dropdwon is not shown on the pager, it sets the visibility of itself to hidden.

const dropDownStyle = { visibility: hidden ? 'hidden' : 'visible' };

This should be display:none. When using visibility, the element is not shown but the screen real-estate for that control is still reserved which results in a pager that is a good bit larger than it needs to be.

However, I also question why this control does not just return null if the drop down is hidden and not render anything at all.

@AllenFang
Copy link
Owner

@waynebrantley v4.3.1 fixed this issue, if options.hideSizePerPage is true, we will not render the sizePerPage dropdown anymore.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants