chore(deps): lock react-addons-test-utils

[Dattaya]

Trying to fix #1246

[coveralls]

Coverage remained the same at 98.605% when pulling ad5afb9 on Dattaya:lock-react-addons-test-utils into 33485f4 on mxstbr:dev.

[Dattaya]

Something installs react-addons-test-utils@15.4 and we're bumping into this bug: facebook/react#8314
I don't understand why recent pull requests pass Travis build but fail AppVeyor. On my Windows machine everything works fine.

[gihrig]

According to this comment, it's not so much a bug as a breaking change in an un-tracked (transient) dependency (react-addons-test-utils).

I have no problem with adding react-addons-test-utils to package.json, but now that react 15.4 has shipped, we should lock react, react-dom and react-addons-test-utils at 15.4. No?

[Dattaya]

Yes, if the other packages work fine with React 15.4, it's better to update libraries from React ecosystem instead of merging this fix. I might need to create another fix for the master branch in case it's affected too, it seems like it is judging from #1246

[Dattaya]

...or update dependencies there too if it's acceptable.

[gihrig]

Master branch includes a yarn.lock, but yarn is not an official (required) dependency of react-boilerplate (yet).

Maybe better to release react-boilerplate 3.3.4 to master with react-addons-test-utils as a dependency. That would be my preference over a hot fix to 3.3.3 master.

@mxstbr, what other open PRs (if any) would you like to see included in 3.3.4?

[gihrig]

@Dattaya I have included react-addons-test-utils@15.4.0 in this week's dependency update #1252. So I'm closing this PR as the issue is fixed in #1252 for dev and IMHO, master should be fixed be fixed by a version update to 3.3.4. I have also closed #1246.

Thank you for taking the time time to research this issue and open the PR! 😄

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.